Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue240 2 #256

Closed
wants to merge 19 commits into from
Closed

Issue240 2 #256

wants to merge 19 commits into from

Conversation

benlapETS
Copy link
Contributor

@benlapETS benlapETS commented Sep 10, 2019

#240. I completed that feature, I added unit test while converting sr_config unit test to unittest framework and also integrated it to flow test.

Unfortunately, I just realised that I didn't automated the fondamental test of this case which is the launch with ssh, but I did it manually with hpfx_amis subcriber. If we want an automated test for that, I think it would make sense to add it to the test suite

@petersilva
Copy link
Contributor

when I try it locally:


Unit tests (Tue Sep 10 16:10:07 EDT 2019)
======= Testing: sr_config
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/unittest/__main__.py", line 12, in <module>
    main(module=None)
  File "/usr/lib/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/lib/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
ImportError: Import by filename is not supported.
======= Testing: sr_util
testing sr_util startup_args
testing sr_util timeflt2str/timestr2flt

It looks like it is using the wrong python version in one script...

@benlapETS
Copy link
Contributor Author

yeah, forgot that in flow setup, this should be working for that now. But on the side of Travis I don't know what is happening but this isn't going well...

@benlapETS
Copy link
Contributor Author

Ok Don't merge that... sarra download is broken... will investigate that tomorrow

@benlapETS
Copy link
Contributor Author

Still got major defects, not passing the flow test. I will need to investigate a little more...

@benlapETS benlapETS closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants