Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V03 make *filetype* an sr3 extra feature, because of dependency issues. #735

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Jul 27, 2023

As explored in #721: There is a new feature in 3.0.42, where the content-type header of each file is included in the message... so people can know the filetype before downloading. It is a mandatory field in the WMO messages, so needed the functionality to be able to export cleanly, and itś a good thing anyways, so added it to base message format.

That required an additional dependency ¨python-magic" It turns out this dependency is troublesome. The debian packaged python packege is python3-magic, the pip install package name is python-magic but that only works on linux. on windows you need to install python-magic-bin. On linux, the debian package has a dependency on libmagic1, but if you install with pip, it won´t pull in the dep... and containers seem to be missing it. So in some cases you need to install libmagic1 by hand separately. A bit of a mess.

Already have a mechanism for dealing with troublesome or fairly optional dependencies, in python they are called extras. but that only covers installation. There is also code built into sr3 to check for presence of extra libraries and only use it if it is present. so ´filetype' is now an extra feature. In this case, it just degrades to omitting the header in the messages it posts.

There is also some missing documentation in the install process, because the amqp library is now an optional extra, and nobody changed the docs... to install you need to install a message passing library as well as the package now, So added that to the documentation.

(some people want to be able to do minimal installs with mqtt, and resented having to have amqp on the machine.)

Also added *all* extra to install all extras.
documenting recent changes (optional filetypes extra) and recent
both languages.
@petersilva petersilva changed the title V03 make *filetype* an sr3 extra feature, because of depency issues. V03 make *filetype* an sr3 extra feature, because of dependency issues. Jul 27, 2023
@petersilva petersilva merged commit aae8ed7 into v03_wip Jul 27, 2023
21 of 22 checks passed
@petersilva petersilva deleted the v03_issue721 branch July 27, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant