Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct metrics miscalculations. #783 #787

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Correct metrics miscalculations. #783 #787

merged 1 commit into from
Oct 20, 2023

Conversation

petersilva
Copy link
Contributor

fixes the display issues, there was an error calculating disconnection time making it a really large negative number if no connection had occurred.

also... -1 values were meant to be defaults for %ages when no data is available, but they look odd. replacing with 0%.

Copy link
Member

@reidsunderland reidsunderland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me

@petersilva petersilva merged commit c80662e into v03_wip Oct 20, 2023
21 of 23 checks passed
@petersilva petersilva deleted the v03_issue783 branch October 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants