Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one way of addressing #827, making dangerWillRobinson a number that m… #831

Closed
wants to merge 2 commits into from

Conversation

petersilva
Copy link
Contributor

This is a first shot at #827... I think getting a count that matches what is being done is a good thing. I don't think y/n prompts help, because the analyst will then ask for a -y option, and in any event if the analyst didn't notice the problem immediately, they could answer yes anyways. having to supply a number that matches the number of configs affected is almost like a 2nd factor. Correlation is a good thing.

So this patch does that, but more is needed prior to merging this:

  • documenting the change in behaviour (cleanup and remove want the number, other ops just require --dangerWillRobinson=1 )
  • when doing sr3 stop and you want to stop even foreground tasks, currently that requires --dangerWillRobinson. That's not super dangerous, so just ask for --dangerWillRobinson=1 for that.

@petersilva petersilva added enhancement New feature or request UserStory interesting to read to consider improving Sugar nice to have features... not super important. labels Nov 17, 2023
@petersilva
Copy link
Contributor Author

If this is good, then merge the sr_insects stuff first:
MetPX/sr_insects#29

@petersilva
Copy link
Contributor Author

merged manually

@petersilva petersilva closed this Nov 20, 2023
@petersilva petersilva deleted the issue827 branch November 20, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sugar nice to have features... not super important. UserStory interesting to read to consider improving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant