Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change raise_signal to os.kill for #948 #957

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Change raise_signal to os.kill for #948 #957

merged 1 commit into from
Mar 7, 2024

Conversation

reidsunderland
Copy link
Member

Fixes #948, raise_signal method doesn't exist on older versions of Python that we still support.

petersilva
petersilva approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after some reading about os.kill and signal.raise calls in various python versions, it looks like using os.kill as proposed in the PR is at least a reasonable approach... it might even be the best approach. ;-)

@petersilva petersilva merged commit 47dd8dc into development Mar 7, 2024
25 of 37 checks passed
@petersilva petersilva deleted the issue948 branch March 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersilva petersilva petersilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raise_signal requires Python >= 3.8
2 participants
@reidsunderland @petersilva