fix(config): backend version is likely to be undefined when invoking …

…isUpdateAvailableAPI
MetaCubeX · Oct 16, 2023 · 398f05d · 398f05d
1 parent 7933583
commit 398f05d
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/pages/Config.tsx b/src/pages/Config.tsx
@@ -467,8 +467,12 @@ const Versions: Component<{ backendVersion: Accessor<string> }> = ({
 }) => {
   const [isUpdateAvailable, setIsUpdateAvailable] = createSignal(false)
 
-  onMount(async () => {
-    setIsUpdateAvailable(await isUpdateAvailableAPI(backendVersion()))
+  createEffect(async () => {
+    const version = backendVersion()
+
+    if (!version) return
+
+    setIsUpdateAvailable(await isUpdateAvailableAPI(version))
   })
 
   return (
@@ -494,15 +498,14 @@ const Versions: Component<{ backendVersion: Accessor<string> }> = ({
 }
 
 export default () => {
+  const [t] = useI18n()
+
   const [backendVersion, setBackendVersion] = createSignal('')
 
   onMount(async () => {
-    const version = await fetchBackendVersionAPI()
-    setBackendVersion(version)
+    setBackendVersion(await fetchBackendVersionAPI())
   })
 
-  const [t] = useI18n()
-
   return (
     <div class="mx-auto flex max-w-screen-md flex-col gap-4">
       <Show when={!isSingBox(backendVersion())}>