Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overview): error when reading length #188

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

nb5p
Copy link
Contributor

@nb5p nb5p commented Sep 8, 2023

No description provided.

@nb5p nb5p closed this Sep 9, 2023
@nb5p
Copy link
Contributor Author

nb5p commented Sep 9, 2023

@nb5p nb5p reopened this Sep 9, 2023
@kunish
Copy link
Collaborator

kunish commented Sep 9, 2023

Is this business still relevant?

@nb5p
Copy link
Contributor Author

nb5p commented Sep 10, 2023

Is this business still relevant?

I don't know. I have noticed that the connections variable is null when the overview page is blank. This indicates that the clash backend may return a null value in certain situations.

@kunish
Copy link
Collaborator

kunish commented Sep 10, 2023

Fix the type definition then, we can merge this

@nb5p
Copy link
Contributor Author

nb5p commented Sep 11, 2023

I will take care of it later.

nb5p and others added 2 commits September 11, 2023 19:27
Signed-off-by: nb5p <2098464+nb5p@users.noreply.github.com>
@kunish kunish merged commit 9f227c9 into MetaCubeX:main Sep 12, 2023
@nb5p nb5p deleted the fix-bug branch September 12, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants