New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MyMeta] ENS usernames #1176
Comments
What if we just added a "Use ENS" checkbox as an alternative to username? Since we already have their ETH address at that point. I'm not sure that we want to store ENS names in our DB (I believe they can expire, be re-assigned, etc). We could support ENS out of the box already by just looking up ENS names from players that have no "username" (name in the profile table I believe) |
I agree with not storing the names. Not only might they be transfered, but we'd also have to worry about people registering someone else's name with ill intent. I like the idea of disallowing It's very similar to the situation with addresses. Usernames of the same format as an address ( I don't think it's necessary to ask them to do it. |
Hey, I found this task on Dework, I've worked on adding ENS support for multiple DAOs and I can see this task through if it's still available. @alalonde |
@dysbulic I'd like to make this task's requirements much more explicit so that new devs can start working on it. How does this sound?
Outstanding questions:
|
Milestones:
Implementation plan:
@alalonde This is my plan, I will do remaining research of implementation tomorrow then begin the set up on Monday. |
@alalonde, @Seroxdesign, rather than having people set their The Simply resolving ENS names adds a small amount of time for the resolution step, but does away with the need for any verification of ownership. If we find resolution time to be an issue, we could keep a cache of ENS name resolutions. Currently, it is possible to set any domain name (that has DNSSEC) to be a valid ENS name, not just Also, rather than assume the user will have their wallet connected or that it will be on mainnet, I think we should simply use a JSONRPCProvider connected to a mainnet RPC endpoint to do the resolution and not rely on the user's wallet. |
We need to verify that they actually have the ENS name, no? So they can't just impersonate e.g. |
If a user visits |
OK, so you're suggesting just looking up the ENS name associated with the player's eth address. Do we make This seems preferable as that takes out all the effort of syncing our usernames with ENS |
Yeah, if there's a
Yeah, I think it should be possible to remove it.
It would work in addition to any ENS names. There would be three ways to access a user's profile: address, username, & ENS name. Since the username can't contain When dereferencing the |
Yup, got it. Thanks for clarifying. @Seroxdesign Does this make sense? It will be a vastly simpler implementation this way. There will be minimal backend work then, perhaps just making |
@alalonde all clear, this makes things a lot easier. Will edit the tasks to follow these recommendations |
@peth-yursick, they're not specifying their ENS name as their username. It's simply that if an ENS name is specified in |
Ready for review |
I don't see this in the PR Also, we should include a data migration in this PR that removes any current usernames with a dot. In fact, you'll have to do this before adding the backend constraint on that column |
What would you like to be added?
The ability for people to set their ENS address as their username.
Why is this needed?
Given its popularity in the space, its kind of embarrassing not to allow people to set their username as so.
The problem seems to be at the ceramic level? You're simply not allows to have . in your username? @dys
The text was updated successfully, but these errors were encountered: