Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ENS set up to web3State #1509

Closed
wants to merge 1 commit into from

Conversation

Seroxdesign
Copy link
Contributor

Overview

What features/fixes does this PR include?

Adding ENS support

Please provide the GitHub issue number

#1176

Closes #

Follow up Improvement Ideas

  • please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

@dysbulic
Copy link
Member

So, three things:

  1. Could you push your branch to the MetaFam/TheGame repo and make a PR from that? The automated test setup doesn't work for branches from remote repositories.
  2. Variable names are camel-cased, with all elements of an acronym being the same case, so the variable would be named ens.
  3. There is still ongoing discussion as to how this feature should be added. If we go my route you won't resolve the reverse address, rather you'll change the routing code for /player/<name> and if name contains a . you'll see if there's an address associated with it in ENS & load that profile.

@Seroxdesign
Copy link
Contributor Author

Closed: Understood, will follow your recommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants