Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several UI and Developer Experience improvements #962

Closed
firattale opened this issue Dec 9, 2021 · 10 comments · Fixed by #1104
Closed

Several UI and Developer Experience improvements #962

firattale opened this issue Dec 9, 2021 · 10 comments · Fixed by #1104
Labels
design needed UI Design related work feature request Feature Requests good 1ˢᵗ issue Easier tasks for new contributors low Low Priority

Comments

@firattale
Copy link
Contributor

firattale commented Dec 9, 2021

What would you like to be added?

1-) Add a Custom 404 Page #1013
2-) Scrolling in the Homepage creates a white blank at top and at bottom. We need to prevent that or change the color to have better color consistency. https://my.metagame.wtf/players #1104
3-) It is good to have path aliases in the import of other components. That would save time to to copy other component's imports or changing any file location. #1082

Why is this needed?

1-) We have a regular Next Js 404 Page, It would be good to use a custom 404 Page, But design needed.

Screenshot 2021-12-08 at 17 26 48

2-)

Screenshot 2021-12-08 at 17 26 06

3-)
@firattale firattale added the feature request Feature Requests label Dec 9, 2021
@vidvidvid
Copy link
Collaborator

vidvidvid commented Dec 9, 2021

Nice suggestions. May I ask what is the url of the 'Homepage' you're referring to, which browser are you using and if you could record this behaviour?

@firattale
Copy link
Contributor Author

hi @vidvidvid , it is happening here https://my.metagame.wtf/players

@vidvidvid
Copy link
Collaborator

ohh, but this is just standard website design, i believe. it's happening on pretty much every website on mac/chrome. we could look into how to change that, but i don't think it needs fixing. just check github, for example, same thing happens here:
white

@firattale
Copy link
Contributor Author

Yes @vidvidvid , that's true, but it is white because in light mode, when you switch to dark mode, that area becomes dark and consistent with theme UI. So we can change it to Metagame purple color.

@vidvidvid
Copy link
Collaborator

ahhh, true!

@vidvidvid vidvidvid added the good 1ˢᵗ issue Easier tasks for new contributors label Dec 9, 2021
@vidvidvid
Copy link
Collaborator

the file for setting the theme can be found in packages/design-system/src/theme/index.ts

@lucidcyborg
Copy link
Member

Could you also look into the flickering effect the animations have in the profiles in this PR?

Schermopname.2021-12-14.om.17.34.53.mov

@firattale
Copy link
Contributor Author

@mquellhorst this might happen because of my recent PR, but haven't seen anything like that in my profile, I will check that.

@firattale
Copy link
Contributor Author

firattale commented Dec 15, 2021

@mquellhorst I check both on my local and live and it seems fine, where did this happen like browser etc? is it possible to reproduce it?

Screen.Recording.2021-12-15.at.11.31.04.mov

@firattale firattale added the design needed UI Design related work label Dec 15, 2021
@lucidcyborg lucidcyborg added the low Low Priority label Dec 15, 2021
@vidvidvid
Copy link
Collaborator

I'll fix 2) in #1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed UI Design related work feature request Feature Requests good 1ˢᵗ issue Easier tasks for new contributors low Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants