Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node v14 #30

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Support Node v14 #30

merged 2 commits into from
Apr 7, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 7, 2023

The minimum (and default) version of Node.js has been changed from v16 to v14. Our libraries still use v14 by default, and metamask-mobile remains on v14 for now (they are in the process of upgrading, but they require additional time to resolve tooling incompatibilities). The v16 minimum had become a blocker to mobile using this package.

This package and all of its dependencies appear to be compatibile with Node v14 already.

The minimum (and default) version of Node.js has been changed from v16
to v14. Our libraries still use v14 by default, and `metamask-mobile`
remains on v14 for now (they are in the process of upgrading, but they
require additional time to resolve tooling incompatibilities). The v16
minimum had become a blocker to mobile using this package.

This package and all of its dependencies appear to be compatibile with
Node v14 already.
@Gudahtt Gudahtt requested a review from a team as a code owner April 7, 2023 14:48
Copy link

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit c8128b7 into main Apr 7, 2023
6 checks passed
@Gudahtt Gudahtt deleted the support-node-v14 branch April 7, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants