Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow publishing packages with version 0.0.0 #61

Closed
wants to merge 2 commits into from
Closed

Disallow publishing packages with version 0.0.0 #61

wants to merge 2 commits into from

Conversation

rickycodes
Copy link
Member

closes #57

@rickycodes rickycodes requested a review from a team as a code owner February 27, 2024 18:47
mcmire
mcmire approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you say you had a fork where you had tested this? Either way, looks good.

@Gudahtt
Copy link
Member

Gudahtt commented Mar 13, 2024

It looks like CI checks aren't being run here because the repository's workflow only runs on push, not on pull_request events. We should be able to update that workflow to run on pull_request as well.

@mcmire
Copy link
Contributor

mcmire commented Mar 14, 2024

@Gudahtt Added here: #62

@rickycodes rickycodes mentioned this pull request Mar 15, 2024
Merged
@rickycodes rickycodes closed this Mar 15, 2024
@Gudahtt
Copy link
Member

Gudahtt commented Mar 15, 2024

Closed in favor of #63 because the shellcheck step doesn't support forks (it silently fails when the GITHUB_TOKEN passed in only has read access to checks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@mikesposito mikesposito mikesposito left review comments

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
team-shared-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow publishing packages with version 0.0.0
5 participants
@rickycodes @Gudahtt @mcmire @mikesposito @MajorLift