Improve Dry Run Output #64
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Hopefully once we remove the chunking from utils (we're just waiting on a new release) then the diff output will be easier to read. I'd also be interested if we can make the job output easier to read — perhaps we can only show debugging information when debug logging is turned on. Either way both of those can wait.
mcmire
added a commit
that referenced
this pull request
May 8, 2024
This reverts commit 0e5aa50. This change will work on a polyrepo, but not on a monorepo. Reverting until we can make it work on both.
Gudahtt
added a commit
that referenced
this pull request
May 10, 2024
* origin/main: remove default channel (#73) Don't fail overall if Slack announcement fails (#69) Improve Dry Run Output (#64) 5.0.0 (#67) Fix Yarn 4 compatibility (#65) Disallow publishing packages with version 0.0.0 (#63) Run linting and testing GitHub workflows on PRs (#62) Enabling MetaMask security code scanner (#60) Add Shared Libraries team in codeowners file (#59) Update README.md (#56) Update README.md (#55) Update README.md (#54) Bump word-wrap from 1.2.3 to 1.2.4 (#53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
here's a resulting artifact: https://github.com/rickycodes/utils/actions/runs/8691496883/job/23834055674#step:4:337