Add contract address validation #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-NFT-contract-address-validation-to-get-URI-method
branch
2 times, most recently
from
d6b084e
to
a5b55e0
Compare
Contract address validation has been added to the `getCollectibleTokenURI` method. This validation was already present in the one place where `getCollectibleTokenURI` is called, so overall this is basically a refactor with no functional changes, except that the API of each of these controllers has changed. It's a non-functional change from mobile's perspective though. It might seem more appropriate to throw an error if the address isn't an NFT, rather than returning an empty string. But this is the pre- existing behaviour, so it has been preserved for now.
Gudahtt
force-pushed
the
add-NFT-contract-address-validation-to-get-URI-method
branch
from
b1c3427
to
09629fa
Compare
Gudahtt
deleted the
add-NFT-contract-address-validation-to-get-URI-method
branch
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Contract address validation has been added to the `getCollectibleTokenURI` method. This validation was already present in the one place where `getCollectibleTokenURI` is called, so overall this is basically a refactor with no functional changes, except that the API of each of these controllers has changed. It's a non-functional change from mobile's perspective though. It might seem more appropriate to throw an error if the address isn't an NFT, rather than returning an empty string. But this is the pre- existing behaviour, so it has been preserved for now.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Contract address validation has been added to the `getCollectibleTokenURI` method. This validation was already present in the one place where `getCollectibleTokenURI` is called, so overall this is basically a refactor with no functional changes, except that the API of each of these controllers has changed. It's a non-functional change from mobile's perspective though. It might seem more appropriate to throw an error if the address isn't an NFT, rather than returning an empty string. But this is the pre- existing behaviour, so it has been preserved for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract address validation has been added to the
getCollectibleTokenURImethod. This validation was already present in the one place wheregetCollectibleTokenURIis called, so overall this is basically a refactor with no functional changes, except that the API of each of these controllers has changed. It's a non-functional change from mobile's perspective though.It might seem more appropriate to throw an error if the address isn't an NFT, rather than returning an empty string. But this is the pre- existing behaviour, so it has been preserved for now.