Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract address validation #414

Merged

Commits on Mar 19, 2021

  1. Add contract address validation

    Contract address validation has been added to the
    `getCollectibleTokenURI` method. This validation was already present in
    the one place where `getCollectibleTokenURI` is called, so overall this
    is basically a refactor with no functional changes, except that the API
    of each of these controllers has changed. It's a non-functional change
    from mobile's perspective though.
    
    It might seem more appropriate to throw an error if the address isn't
    an NFT, rather than returning an empty string. But this is the pre-
    existing behaviour, so it has been preserved for now.
    Gudahtt committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    09629fa View commit details
    Browse the repository at this point in the history