-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom network gas #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
previously approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. matches very closely with the implementation in extension.
brad-decker
previously approved these changes
Jul 1, 2021
wachunei
reviewed
Jul 7, 2021
wachunei
previously approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brad-decker
approved these changes
Jul 9, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added gas calculation support for custom networks * added comments to new code * lint fix * updated composable test case * added flag to required test cases * updated switch logic * updated mock custom network state * converted chainIds from hex to decimal * updated tests * state using update method * state using update test cases * method naming update
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* added gas calculation support for custom networks * added comments to new code * lint fix * updated composable test case * added flag to required test cases * updated switch logic * updated mock custom network state * converted chainIds from hex to decimal * updated tests * state using update method * state using update test cases * method naming update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for custom networks and gas calculation