Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom network gas #505

Merged
merged 17 commits into from
Jul 9, 2021
Merged

Feature/custom network gas #505

merged 17 commits into from
Jul 9, 2021

Conversation

sethkfman
Copy link
Contributor

Added support for custom networks and gas calculation

  • NetworkController: added boolean to network state to identify a custom network
  • NetworkController: added optimism to enum
  • TransactionController: in estimateGas add logic for custom networks to raw eth_estimateGas value
  • Updated unit tests in Network & Transaction Controller

@sethkfman sethkfman requested a review from a team as a code owner July 1, 2021 17:51
brad-decker
brad-decker previously approved these changes Jul 1, 2021
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. matches very closely with the implementation in extension.

brad-decker
brad-decker previously approved these changes Jul 1, 2021
wachunei
wachunei previously approved these changes Jul 8, 2021
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 809ed75 into main Jul 9, 2021
@sethkfman sethkfman deleted the feature/custom-network-gas branch July 9, 2021 18:22
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* added gas calculation support for custom networks

* added comments to new code

* lint fix

* updated composable test case

* added flag to required test cases

* updated switch logic

* updated mock custom network state

* converted chainIds from hex to decimal

* updated tests

* state using update method

* state using update test cases

* method naming update
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* added gas calculation support for custom networks

* added comments to new code

* lint fix

* updated composable test case

* added flag to required test cases

* updated switch logic

* updated mock custom network state

* converted chainIds from hex to decimal

* updated tests

* state using update method

* state using update test cases

* method naming update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants