mutex

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@metamask/controllers",
-  "version": "5.1.0",
+  "version": "5.1.2",
   "description": "Collection of platform-agnostic modules for creating secure data models for cryptocurrency wallets",
   "license": "MIT",
   "files": [

src/transaction/TransactionController.ts

@@ -3,7 +3,6 @@ import { addHexPrefix, bufferToHex } from 'ethereumjs-util';
 import { ethErrors } from 'eth-rpc-errors';
 import BaseController, { BaseConfig, BaseState } from '../BaseController';
 import NetworkController from '../network/NetworkController';
-
 import {
   BNToHex,
   fractionBN,
@@ -471,6 +470,7 @@ export class TransactionController extends BaseController<TransactionConfig, Tra
    * @returns - Promise resolving when this operation completes
    */
   async approveTransaction(transactionID: string) {
+    const releaseLock = await this.mutex.acquire();
     const { transactions } = this.state;
     const network = this.context.NetworkController as NetworkController;
     /* istanbul ignore next */
@@ -481,9 +481,11 @@ export class TransactionController extends BaseController<TransactionConfig, Tra
 
     if (!this.sign) {
       this.failTransaction(transactionMeta, new Error('No sign method defined.'));
+      releaseLock();
       return;
     } else if (!currentChainId) {
       this.failTransaction(transactionMeta, new Error('No chainId defined.'));
+      releaseLock();
       return;
     }
 
@@ -505,7 +507,9 @@ export class TransactionController extends BaseController<TransactionConfig, Tra
       transactionMeta.status = 'submitted';
       this.updateTransaction(transactionMeta);
       this.hub.emit(`${transactionMeta.id}:finished`, transactionMeta);
+      releaseLock();
     } catch (error) {
+      releaseLock();
       this.failTransaction(transactionMeta, error);
     }
   }