Skip to content

Commit

Permalink
Add BaseControllerV2 support to ComposableController
Browse files Browse the repository at this point in the history
The ComposableController now supports controllers that are based upon
BaseControllerV2. These newer controllers use the controller messaging
system to communicate, so the messenger is now a required constructor
parameter if any BaseControllerV2 controllers are used.

The `name` property in `BaseControllerV2` had to be made public for the
ComposableController to properly construct its state. This seems OK. It
was only kept private initially until a use was found for it.
  • Loading branch information
Gudahtt committed Apr 19, 2021
1 parent 7c7eb66 commit c38021a
Show file tree
Hide file tree
Showing 4 changed files with 554 additions and 161 deletions.
2 changes: 1 addition & 1 deletion src/BaseControllerV2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class BaseController<
string | never
>;

private name: N;
public readonly name: N;

public readonly metadata: StateMetadata<S>;

Expand Down
Loading

0 comments on commit c38021a

Please sign in to comment.