fix: simulation should handle NFT mints #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrans
added
the
team-confirmations-system
matthewwalsh0
previously approved these changes
Apr 26, 2024
matthewwalsh0
approved these changes
Apr 29, 2024
Merged
dbrans
added a commit
that referenced
this pull request
Apr 30, 2024
Creates release 145, to release v28.1.1 of the TransactionController. The intention is to hotfix transaction-controller 28.1.1 into the Extension along with #4217 --------- Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
7 tasks
dbrans
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Apr 30, 2024
…on (#24306) ## **Description** Update transaction-controller core package to bring in this fix to NFT mint simulation: MetaMask/core#4217 [](https://codespaces.new/MetaMask/metamask-extension/pull/24306?quickstart=1) ## **Related issues** Fixes: #24251 ## **Manual testing steps** 1. Visit https://www.fxhash.xyz/generative/slug/g-l-y-p-h 2. Try minting the nft 3. Simulation should work and show the nft in the "You receive" section. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** (Simulation Failed message) ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/24306?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the token balance change simulation logic to correctly handle NFT mints. Previously, the code was attempting to simulate a "before" balance check transaction for newly minted NFTs using
ownerOf, which would revert since the token ID does not exist prior to the mint.Key changes:
getTokenBalanceTransactionsto only include an "after" balance transaction for NFT mints, identified by thefromaddress being the zero address in theTransferevent.getTokenBalanceChangesto assume a previous balance of zero for newly minted NFTs and skip the "before" balance check transaction.References
Changelog
@metamask/transaction-controllerChecklist