Release 146.0.0 #4232
Merged
Release 146.0.0 #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Apr 30, 2024
|
|
||
| ### Fixed | ||
|
|
||
| - Fix misnamed parameter name ([#4108](https://github.com/MetaMask/core/pull/4108)) |
There was a problem hiding this comment.
This is an internal parameter, so I think we can omit it from the changelog. It doesn't impact the API at all
Gudahtt
reviewed
Apr 30, 2024
mikesposito
reviewed
Apr 30, 2024
|
|
||
| ### Changed | ||
|
|
||
| - Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
There was a problem hiding this comment.
Small typo:
Suggested change
| - Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) | |
| - Updated polling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
or alternatively:
Suggested change
| - Updated pooling intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) | |
| - Changed lists refresh intervals ([#4202](https://github.com/MetaMask/core/pull/4202)) |
There was a problem hiding this comment.
It is been updated to
- Changed Stalelist and hotlist intervals ([#4202](https://github.com/MetaMask/core/pull/4202))
Merged
Gudahtt
previously approved these changes
Apr 30, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
reviewed
Apr 30, 2024
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Mrtenz
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This release includes
Phishing Controller
~9.1.0~4.9.5Base Controller
~4.9.5References
Changelog
@metamask/phishing-controller~4.9.5@metamask/base-controller~4.9.5Checklist