Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Export ETHERSCAN_SUPPORTED_CHAIN_IDS constant from Preferences Controller #4233

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: Export ETHERSCAN_SUPPORTED_CHAIN_IDS constant from Preferences Controller #4233

merged 1 commit into from
Apr 30, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 30, 2024 •
edited

Explanation

References

Changelog

@metamask/preferences-controller

  • : export of ETHERSCAN_SUPPORTED_CHAIN_IDS for clients

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini tommasini requested a review from a team as a code owner April 30, 2024 13:49
@tommasini tommasini mentioned this pull request Apr 30, 2024
Merged
7 tasks
Gudahtt
Gudahtt approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini merged commit 8c80ba4 into main Apr 30, 2024
139 checks passed
@tommasini tommasini deleted the chore/export-etherscan-supported-chain-ids branch April 30, 2024 14:56
@Gudahtt Gudahtt mentioned this pull request May 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tommasini @Gudahtt