TokenService improvements #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we need this for every api endpoint, eh? |
kumavis
changed the title
|
please verify my changes are sound around |
ryanml
reviewed
Jul 28, 2021
| async function parseJsonResponse(apiResponse: Response): Promise<unknown> { | ||
| const responseObj = await apiResponse.json(); | ||
| // api may return errors as json without setting an error http status code | ||
| if (responseObj?.error) { |
There was a problem hiding this comment.
nit: Is the ? necessary given we are checking for the props existence in the first place?
There was a problem hiding this comment.
responseObj could be null, thats valid json
unlikely tho
Merged
rickycodes
added a commit
that referenced
this pull request
Aug 3, 2021
…to dynamic-speed-up * 'dynamic-speed-up' of github.com:MetaMask/controllers: Bump @metamask/auto-changelog from 2.4.0 to 2.5.0 (#549) Update Changelog (#548) 14.0.2 (#547) Fix `resetPolling` functionality (#546) TokenService improvements (#541) Release/14.0.1 (#545) Make gweiDecToWEIBN util resilient against params with too many decimals (#544) Bump @metamask/contract-metadata from 1.27.0 to 1.28.0 (#540) 14.0.0 (#539) Bug: Mainnet NFT Autodetect API (#536)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Update token-service.ts * Update token-service.ts * Update token-service.ts * lint fix * token-service - break out parsing of response to only those that have a response * TokenListController - fallback to empty array * TokenListController - remove unsound safety wrapper * TokenListController - fix endpoint for token lookup * lint fix
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Update token-service.ts * Update token-service.ts * Update token-service.ts * lint fix * token-service - break out parsing of response to only those that have a response * TokenListController - fallback to empty array * TokenListController - remove unsound safety wrapper * TokenListController - fix endpoint for token lookup * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should check for that an elevate to an error
safelyExecuteusagesafelyExecuteusagei guess this is a breaking change bc types?