New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Manage transaction state #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions! Nothing major though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny comment non-blocking nits. LGTM!
Description
This development only affects the mobile app since the extension has its own Transaction Controller
Improvement on how we process transaction state by updating the Transaction Controller. The extension currently has a Transaction State Controller to handle user scenarios, something we lack.
Use Cases
The states of transactions 2 transactions with same nonce are shown wrongly.