Add KeyringController tests #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
approved these changes
Mar 25, 2019
| @@ -184,7 +211,7 @@ export class KeyringController extends BaseController<BaseConfig, KeyringState> | |||
| * @param password - Password of the keyring | |||
| * @returns - Promise resolving to the seed phrase | |||
| */ | |||
| exportSeedPhrase(password: string): Promise<string> { | |||
| exportSeedPhrase(password: string) { | |||
There was a problem hiding this comment.
Why did you remove the return type here?
There was a problem hiding this comment.
it doesn't return a promise, only a string. Found with the test for this method.
bitpshr
approved these changes
Mar 25, 2019
kanthesha
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* improve types definition * testing progress * add types and istanbul ignore * add rest of tests * add missing doc * handle async methods tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* improve types definition * testing progress * add types and istanbul ignore * add rest of tests * add missing doc * handle async methods tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds full coverage tests of
KeyringController.Resolves #66