Add rules for hybrid Node.js and browser environments (#242)

* Add package for hybrid Node.js and browser environments

* Add default message to every item

* Fix changelog formatting

* Use existing no-undef and import/no-nodejs-modules rules

* Fix yarn.lock

* Add env

* Add env to test

.eslintrc.js

@@ -1,6 +1,10 @@
 module.exports = {
   root: true,
 
+  env: {
+    node: true,
+  },
+
   parserOptions: {
     ecmaVersion: 2018,
   },
@@ -13,6 +17,7 @@ module.exports = {
 
   rules: {
     'import/no-dynamic-require': 'off',
+    'import/no-nodejs-modules': 'off',
     'node/global-require': 'off',
     'node/no-process-exit': 'off',
     'node/no-sync': 'off',

packages/base/rules-snapshot.json

@@ -119,6 +119,7 @@
   "import/no-named-as-default": "error",
   "import/no-named-as-default-member": "error",
   "import/no-named-default": "error",
+  "import/no-nodejs-modules": "error",
   "import/no-self-import": "error",
   "import/no-unassigned-import": "error",
   "import/no-unresolved": [

packages/base/src/index.js

@@ -313,6 +313,7 @@ module.exports = {
     'import/no-named-as-default': 'error',
     'import/no-named-as-default-member': 'error',
     'import/no-named-default': 'error',
+    'import/no-nodejs-modules': 'error',
     'import/no-self-import': 'error',
     'import/no-unassigned-import': 'error',
     'import/no-unresolved': [

packages/typescript/rules-snapshot.json

@@ -101,7 +101,7 @@
   "no-shadow": "off",
   "no-this-before-super": "off",
   "no-throw-literal": "off",
-  "no-undef": "off",
+  "no-undef": "error",
   "no-unreachable": "off",
   "no-unsafe-negation": "off",
   "no-unused-expressions": "off",

packages/typescript/src/index.js

@@ -32,6 +32,7 @@ module.exports = {
     'import/no-unresolved': 'off',
 
     // Our rules
+    'no-undef': 'error',
     '@typescript-eslint/array-type': 'error',
     '@typescript-eslint/consistent-type-assertions': 'error',
     '@typescript-eslint/consistent-type-definitions': ['error', 'type'],

packages/typescript/src/index.test.js

@@ -6,6 +6,11 @@ describe('index', () => {
   it('is a valid ESLint config', async () => {
     const api = new ESLint({
       baseConfig: config,
+      overrideConfig: {
+        env: {
+          node: true,
+        },
+      },
       useEslintrc: false,
     });