Extend recommended plugin rules in all configs #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Apr 2, 2021
| "no-unused-expressions": "off", | ||
| "no-unused-vars": "off", | ||
| "no-use-before-define": "off", | ||
| "no-useless-constructor": "off", | ||
| "no-var": "error", |
There was a problem hiding this comment.
These four seem new 🤔 These aren't even TypeScript rules. What's going on here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the recommended rules of the corresponding plugin for the
mocha,nodejs, andtypescriptconfigs.The
nodejsrecommended rules added a single, deprecated core rule, which we now disable in our config.The
mocharecommended rules addsmocha/no-exports, which seems good.The
typescriptrecommended rules adds a bunch of previously absent rules to the snapshot for that config, however almost all of them are already disabled in our base config. In f30711b, I removed some extraneous rules, which you'll notice didn't affect the snapshot.Following this PR, I will remove all rules that we specify that are identical to those we find in the plugins' recommended rule sets. Then, we can publish a new major version of this package and start using it.