Fix the lint script
#204
Merged
Fix the lint script
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You hate to see it. |
The `lint` npm script was not running the "miscellaneous" lints correctly because the `--check` flag was missing. So instead of checking for lint errors and returning non-zero if any problems were found, it was printing all matched files to the console. When the `--check` flag was restored, it became clear that the `lint:fix` script could no longer pass because the `config-validation` lint step was generating invalid snapshots. The `config-validation` script was run last, and didn't run `prettier` on the rules before writing them to disk. `prettier` is now run on the snapshots before writing them to disk, which ensures `lint:fix` and `lint` won't get into any more disagreements.
Gudahtt
force-pushed
the
fix-lint-script
branch
from
74580ea
to
e4756d4
Compare
|
@rekmarks Description updated! Found another related problem. |
rekmarks
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lintnpm script was not running the "miscellaneous" lints correctly because the--checkflag was missing. So instead of checking for lint errors and returning non-zero if any problems were found, it was printing all matched files to the console.When the
--checkflag was restored, it became clear that thelint:fixscript could no longer pass because theconfig-validationlint step was generating invalid snapshots. Theconfig-validationscript was run last, and didn't runprettieron the rules before writing them to disk.prettieris now run on the snapshots before writing them to disk, which ensureslint:fixandlintwon't get into any more disagreements.