Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: jest@29.3.1->29.6.1 #305

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@socket-security
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/jest 29.2.2...29.5.2 None +0/-27 79.3 kB types

🚮 Removed packages: jest@29.3.1

@socket-security
Copy link

socket-security bot commented Jul 12, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @nicolo-ribaudo/semver-v6@6.3.3, semver@6.3.1, semver@7.5.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @nicolo-ribaudo/semver-v6@6.3.3
@SocketSecurity ignore semver@6.3.1
@SocketSecurity ignore semver@7.5.4

6.3.1 should ideally be dropped but pulled in through neglected istanbul for jest.

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jul 12, 2023
@legobeat legobeat marked this pull request as ready for review July 12, 2023 07:12
@legobeat legobeat requested a review from a team as a code owner July 12, 2023 07:12
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 7af57a6 into MetaMask:main Jul 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants