New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable @typescript-eslint/no-unnecessary-type-assertion #333

Draft

mcmire wants to merge 3 commits into main from disable-no-unnecessary-type-assertion

Commits on Oct 31, 2023

Bump min Node to 16, and use LTS Node for dev

**This change is breaking.**

We could bump this monorepo to Node 18, but since these packages are
heavily depended upon, we don't need to do that yet until we've
confirmed all other projects are using 18.

Using the LTS version of Node puts us on a more modern version for
development (and also happens to fix the `.nvmrc` file so `asdf` can
read it).

mcmire committed Oct 31, 2023

Update README

mcmire committed Oct 31, 2023
Configuration menu
View commit details

Copy full SHA for 2d297a7

Browse repository at this point
Copy the full SHA

2d297a7 View commit details

Browse the repository at this point in the history

Disable @typescript-eslint/no-unnecessary-type-assertion

This rule, as we've discovered after running it against the `core`
monorepo, seems to produce false negatives. If you look at the issues
list for the `typescript-eslint` repo and filter by this rule, you'll
notice that [other people have reported this as well][1]. As a result,
it's not worth enabling right now.

[1]: https://github.com/typescript-eslint/typescript-eslint/issues?q=is%3Aissue+is%3Aopen+no-unnecessary-type-assertion+sort%3Aupdated-desc

mcmire committed Oct 31, 2023