Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 #60

Merged
merged 3 commits into from May 4, 2022
Merged

6.0.0 #60

merged 3 commits into from May 4, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2022

Added

  • Add TypeScript type definitions (#58)

Changed

  • Rename package to @metamask/eth-json-rpc-infura (#61)
    • eth-json-rpc-infura is deprecated and future releases will no longer occur under this name.
  • BREAKING: Upgrade dependencies to make use of new TypeScript type definitions (#58)
    • eth-json-rpc-middleware: ^6.0.0 -> ^8.1.0 (changelog)
    • eth-rpc-errors: ^3.0.0 -> ^4.0.3 (changelog)
    • json-rpc-engine: ^5.3.0 -> ^6.1.0 (changelog)
  • BREAKING: Simplify exports (#58)
    • All existing exports are now available under the package entrypoint. For instance, instead of:
      import createProvider from 'eth-json-rpc-infura/src/createProvider';
      
      you must now say:
      import { createProvider } from '@metamask/eth-json-rpc-infura';
      

Security

@mcmire mcmire force-pushed the release/6.0.0 branch 4 times, most recently from 25b29f0 to c5e96f6 Compare May 2, 2022 19:02
@mcmire mcmire marked this pull request as ready for review May 2, 2022 19:04
@mcmire mcmire requested a review from a team as a code owner May 2, 2022 19:04
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one important breaking change missing: a minimum Node.js version was set in #44

CHANGELOG.md Outdated
### Changed
- Rename package to `@metamask/eth-json-rpc-infura` ([#61](https://github.com/MetaMask/eth-json-rpc-infura/pull/61))
- `eth-json-rpc-infura` is deprecated and future releases will no longer occur under this name.
- **BREAKING:** Upgrade dependencies to make use of new TypeScript type definitions ([#58](https://github.com/MetaMask/eth-json-rpc-infura/pull/58))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes breaking for a project using this package? I wouldn't typically consider dependency changes as breaking

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah, I suppose if a consumer is relying on some functionality from these packages they should add them as direct dependencies. Removed in a3dc1eb.

@Gudahtt
Copy link
Member

Gudahtt commented May 4, 2022

The rest of the changelog looks good though!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 2c56140 into main May 4, 2022
@mcmire mcmire deleted the release/6.0.0 branch May 4, 2022 17:45
@mcmire
Copy link
Contributor

mcmire commented May 4, 2022

Ready to be published.

@Gudahtt
Copy link
Member

Gudahtt commented May 4, 2022

A new version of the package @metamask/eth-json-rpc-infura (6.0.0) was published at 2022-05-04T17:59:13.157Z from
[redacted]. The shasum of this package was 1c9a74853bdf3eb5cd8642bbca06b0e4e3620394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants