Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useLedgerLive setting isn't always in sync #88

Open
darkwing opened this issue Jul 25, 2021 · 1 comment
Open

useLedgerLive setting isn't always in sync #88

darkwing opened this issue Jul 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@darkwing
Copy link
Contributor

This is fairly simple to reproduce:

  1. Connect a Ledger account to MetaMask
  2. (eth-ledger-bridge-keyring injects the github pages iframe with correct useLedgerLive setting)
  3. Use the test dapp to perform a signature
  4. Remove the Ledger account from MetaMask
  5. Add the account again

The useLedgerLive setting will be false in the IFrame, leading to the user's browser hanging (while the iframe incorrectly tries U2F.

Presently MetaMask sends the useLedgerLive setting down to the iframe when the user logs in, and when they toggle the setting. That isn't reliable enough in some cases.

@darkwing darkwing added the bug Something isn't working label Jul 25, 2021
@darkwing
Copy link
Contributor Author

The best solution here is probably going to be removing the useLedgerLive setting everywhere (extension and keyring) and simply enforcing Ledger Live for Chrome (since U2F won't be returning to Chrome) and U2F for Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant