Senior Software Engineer, Front-End Developer, @mootools Core Developer, Javascript Fanatic, CSS Tinkerer, Node Hacker, web and open source lover.
-
Mozilla
- Madison, Wisconsin, United States
- https://davidwalsh.name
Block or Report
Block or report darkwing
Report abuse
Contact GitHub support about this user’s behavior. Learn more about reporting abuse.
Report abusePopular repositories
1,133 contributions in the last year
We're celebrating 100 million developers!
Less
More
Contribution activity
January 2023
Created 21 commits in 2 repositories
Created a pull request in MetaMask/metamask-extension that received 9 comments
Fix #17385 - Provide autohide callback for ActionMessage
Explanation Fixes #17385 When the autohide timer goes off, we should record the event so state updates and the ActionableMessage doesn't display …
+15
−2
•
9
comments
Opened 20 other pull requests in 1 repository
MetaMask/metamask-extension
9
open
11
merged
- Update overview icons for buy, send, and swap
- New Icons: Replace instance of fa-qr-code icon
- Update home portfolio dapp icon to new icon
- Fix #17441 - Update all MenuItem instances to use new icons
- UX - Update all copy icons
- Fix #17362 - Ensure NFT icons are correct
- NFTs: Remove feature flag for release
- Fix #17328 - Move NFT settings to Experimental
- Fix #17393 - Fix NFT collection header image
- Fix #17388 - Remove dismiss button from NFT notification
- Fix #17300, #16843 - Use proper source for image of IPFS NFTs
- Fix #17138 - Allow ActionMessage to be autohidden after a given number of milliseconds
- Fix #17162 - Add NFT disclaimer to details page
- Fix #17142 - Ensure toggle arrow is visible in dark mode
- NFTs: Add proper padding to import warning
- Fix 16842 - Update NFT error message so that it's caught properly and displayed
- Ensure the NFT feature flag has changed in all places
- Onboarding V2 - Fix CSS/React warnings from last screen
- Onboarding v2: Implement requested metrics
- Onboarding V2: Remove old onboarding flow
Reviewed 34 pull requests in 2 repositories
MetaMask/metamask-extension
25 pull requests
- Refactor confirm page container component from class to functional co…
- Updating nft autodetection toggle text, css fix
- Onboarding Unit Tests
-
Add tests for
retryOnEmpty
middleware - Document callback-style background calls as deprecated
- Nft build for e2e tests
- Improving getMemoizedMetadataContractName selector
- Fix #17328 - Move NFT settings to Experimental
- Feat/15086/add banner severities component
- Add alt text for NFT images
- Remove a notification for falling back from STX to regular swaps
- Fix broken NFT import and auto-detect flows
- Convert app//scripts/lib/util.js to typescript
- Restore support for Chromium v78
- Fix for overlapping text in transaction list item
- Enable the Token Allowance flow by default for all users
- Use PageContainerFooter to render footer on all confirmation pages
- Added toaster for removed NFTs
- Added storybook check to CI
- TransactionDecoding: rm unwanted cursor: pointer
- Added title for each nft in send asset dropdown
- updated initial state of new imported nfts to expanded
- Various NFT UI fixes
- Updated Icons in Title of NFTs
- Onboarding v2: Implement requested metrics
- Some pull request reviews not shown.
MetaMask/eth-trezor-keyring
1 pull request
Created an issue in MetaMask/metamask-extension that received 2 comments
NFTs: Settings required to import aren't logically communicated
Describe the bug Nidhi and I couldn't figure out why she wasn't having a problem importing an NFT bought from OpenSea. It turned out the problem wa…
2
comments
Opened 24 other issues in 1 repository
MetaMask/metamask-extension
5
open
19
closed
- UX: Replace all FontAwesome Icons with New Icons
- UX Papercut: Update all instances of MenuItem to use new component library icons
- NFTs: Fix Collection Header Image when IPFS Address
- NFTs: Prevent NFT Autodetect notification from being dismissable
- NFTs: The disappearing toast reappears when you navigate away and then back
- NFTs: Ensure proper icons are used in transaction feed
- NFTs: Fix Missing Image on Details Screen
-
NFTs: Provide
alt
attributes on all NFT imagery - NFTs: Implement "Detection turned off" notification
- NFTs: Importing a previously sent NFT still displays NFT in the "Previously Owned" group
- NFTs: Show disclaimer on NFT detail screen
- NFTs: Use new icon for NFT transfers in activity feed
- NFTs: Newly imported NFT group begins as closed
- NFTs: Icon before title should be thumbnail of first NFT
- NFTs: Send Asset Dropdown doesn't always provide title for each NFT
- NFTs: Improve CollectibleDetail Storybook Coverage
- NFTs: Info icon is misaligned
- NFTs: Attempting to import an NFT not owned by the displays odd behavior
- NFTs: Data URI NFTs shouldn't have their URL as a link
- NFTs: Thumbnails are not accessible via keyboard
- NFTs: Toggle arrow is difficult to see in dark mode
- NFTs: Clicking "Remove item" removes item without feedback
- NFTs: Group title is too close to circle, not vertically centered
- NFTs: Toaster notification never goes away naturally