Use standard TypeScript config #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
use-standard-typescript-config
branch
2 times, most recently
from
46aa107
to
4d7681e
Compare
The TypeScript config has been updated to match the configuration we use in other libraries, mostly. The remaining differences are that `strict` is still not enabled, and there is a separate config used for testing. The test config was preserved for now, but that will be replaced soon when we migrate the tests to Jest. `strict` mode will be enabled in a later PR after we update dependencies, as that will make the necessary changes much easier. The changes are: * `inlineSources` has been enabled. This embeds a complete copy of the source code with the source maps, allowing for a much better debugging experience. * `lib` has been set to `ES2020`, ensuring that we only rely upon JavaScript APIs. Previously it also allowed use of browser APIs. * `rootDir` is now set explicitly to `src`, which will help ensure we don't accidentally change the structure of the package. * The old `prod` config was merged with the base config, so it was no longer needed as a separate file. Closes #142
Gudahtt
force-pushed
the
use-standard-typescript-config
branch
from
4d7681e
to
7b3fa04
Compare
rekmarks
reviewed
Jul 15, 2021
Comment on lines
+6
to
+7
| "rootDir": "", | ||
| "outDir": "", |
There was a problem hiding this comment.
I've never seen this before. Do we output the test index.js to the repo root?
There was a problem hiding this comment.
Nope! Seemingly this "unsets" the outDir set in the base config. So it defaults to outputting it alongside the source, in the test directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript config has been updated to match the configuration we use in other libraries, mostly. The remaining differences are that
strictis still not enabled, and there is a separate config used for testing. The test config was preserved for now, but that will be replaced soon when we migrate the tests to Jest.strictmode will be enabled in a later PR after we update dependencies, as that will make the necessary changes much easier.The changes are:
inlineSourceshas been enabled. This embeds a complete copy of the source code with the source maps, allowing for a much better debugging experience.libhas been set toES2020, ensuring that we only rely upon JavaScript APIs. Previously it also allowed use of browser APIs.rootDiris now set explicitly tosrc, which will help ensure we don't accidentally change the structure of the package.prodconfig was merged with the base config, so it was no longer needed as a separate file.Closes #142