Add encode data tests #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-encode-data-tests
branch
from
26e0e45
to
a8b29eb
Compare
Gudahtt
force-pushed
the
add-encode-data-tests
branch
2 times, most recently
from
9496871
to
ea3dcbb
Compare
Gudahtt
force-pushed
the
add-encode-data-tests
branch
from
ea3dcbb
to
37ee5ab
Compare
Gudahtt
changed the base branch from
main
to
allow-sign-typed-data-utilties-to-be-called-unbound
Base automatically changed from
allow-sign-typed-data-utilties-to-be-called-unbound
to
main
August 3, 2021 18:41
Gudahtt
force-pushed
the
add-encode-data-tests
branch
from
37ee5ab
to
26982ac
Compare
Gudahtt
force-pushed
the
add-encode-data-tests
branch
2 times, most recently
from
082f3f5
to
b41746f
Compare
The function `TypedDataUtils.encodeData` has been thoroughly tested with all novel inputs I could think of. Each supported version (V3 and V4) have been tested independently with each input. There are also tests for each input that should have an identical encoding between V3 and V4, and each that should have non-matching signatures. The structure of the tests is explained in a large inline comment at the start of the `describe` block for `TypedDataUtils.encodeData`. The `encodeData` assertions that accompanied the signature tests have been deleted, as they're now redundant.
Gudahtt
force-pushed
the
add-encode-data-tests
branch
from
b41746f
to
6e0a88d
Compare
|
This PR has been updated with more inline comments explaining what the tests are for. |
Gudahtt
commented
Aug 10, 2021
| // Reassigned to silence "no-loop-func" ESLint rule | ||
| // It was complaining because it saw that `it` and `expect` as "modified variables from the outer scope" | ||
| // which can be dangerous to reference in a loop. But they aren't modified in this case, just invoked. | ||
| const _expect = expect; |
There was a problem hiding this comment.
I really wish there was some way to silence this false positive. I didn't want to disable the rule for the whole file because it's genuinely useful still, but this is irritating.
rekmarks
requested changes
Aug 10, 2021
| ), | ||
| ]; | ||
|
|
||
| describe('TypedDataUtils.encodeData', function () { |
There was a problem hiding this comment.
Why are we not using arrow functions for the callbacks in this test suite? mocha hangover?
There was a problem hiding this comment.
Ah, right 😅
I was just following existing conventions (I think?). Probably better to use arrow functions, but maybe we can do this in one pass later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
TypedDataUtils.encodeDatahas been thoroughly tested with all novel inputs I could think of. Each supported version (V3 and V4) have been tested independently with each input. There are also tests for each input that should have an identical encoding between V3 and V4, and each that should have non-matching signatures.The structure of the tests is explained in a large inline comment at the start of the
describeblock forTypedDataUtils.encodeData.The
encodeDataassertions that accompanied the signature tests have been deleted, as they're now redundant.