-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added decryptMessage
function for implementation eth_decryptMessage
#15
Conversation
What is the reason for such a long delay? 1.5 month passed, can someone speed up this process? I want to do a pull request to Metamask extension, but without this merge, it will be useless. It will let us use new significant features for crypto-chatting. |
Looking to merge this soon, sorry for the long delay. There are still questions about how a user consents to a site's request decryption (is it per packet, or per session, or what?), but we are hoping to fold this into our development branch of our login permissions branch here, as one avenue for user consent that aligns well with a variety of other features we are pursuing to increase dapp access to useful APIs. |
This PR only for the ability to use decryption message in Metamask extension. In Metamask extension we will have the same window as we have for signing some message. If a user will allow signing, that Dapp will receive a signed message, if not, then the request will be declined. The same for message decryption. We can discuss user interaction flow into Metamask repository. |
Could you fix the conflicts on this PR? Some changes were made to |
Some good news: Once this is merged, |
@danfinlay the conflicts are resolved. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just one more change and I'd be willing to merge this.
Removed the unused new dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thank you!
Added a CI fix on another PR: #23 |
Closing as merged in #23 Published to npm as version 3.2.0. |
We need to add it for implementation MetaMask/metamask-extension#1190