Repo standardization #142
Merged
Repo standardization #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enforcing minimum node version 12 via .nvmrc, and the package file * Adding basic .gitattributes file * Adding basic .editorconfig file
ryanml
commented
Apr 11, 2021
| @@ -61,7 +61,7 @@ describe('MetaMaskInpageProvider: Miscellanea', () => { | |||
|
|
|||
| expect( | |||
| () => new MetaMaskInpageProvider(stream, null), | |||
| ).toThrow('Cannot destructure property `jsonRpcStreamName` of \'undefined\' or \'null\''); | |||
| ).toThrow('Cannot read property \'jsonRpcStreamName\' of null'); | |||
There was a problem hiding this comment.
This might be a harmless side effect of the node 10 -> 12 update, but I want to double confirm, so this is a tentative change for now
There was a problem hiding this comment.
It looks like a difference between v10 and v12, specifically in the case when you're using a destructured function parameter with a default value, and you invoke it with null for that parameter.
const test = ({ bar = 'foo' } = {}) => console.log(bar)
test(null);
^ That example throws this on v10: TypeError: Cannot destructure property bar of 'undefined' or 'null'.
but throws this on v12: Uncaught TypeError: Cannot read property 'bar' of null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/MetaMask/MetaMask-planning/issues/32