Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bip122:p2wpkh account support #294

Merged
merged 2 commits into from
Apr 25, 2024
Merged

feat: add bip122:p2wpkh account support #294

merged 2 commits into from
Apr 25, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 24, 2024 •
edited
Loading

Requires

This PR needs to be merged first:

Description

This adds a new account type for bip122 family.

@ccharly ccharly requested a review from a team as a code owner April 24, 2024 11:22
@socket-security Socket Security
Copy link

socket-security bot commented Apr 24, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/bech32@2.0.0 None 0 10.2 kB junderw

View full report↗︎

@ccharly ccharly added the team-accounts This should be handled by the Accounts Team label Apr 24, 2024
danroc
danroc approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@danroc danroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe we should consider refactoring the previous one that separated the KeyringAccount type into different account type definitions.

@ccharly ccharly added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 042caf7 Apr 25, 2024
16 checks passed
@ccharly ccharly deleted the feature/bip122 branch April 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroc danroc danroc approved these changes

Assignees
No one assigned
Labels
team-accounts This should be handled by the Accounts Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccharly @danroc