Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on Snaps known errors. #1117

Merged
merged 7 commits into from Feb 2, 2024
Merged

Conversation

ziad-saab
Copy link
Contributor

Closes MetaMask/metamask-planning#1938.

@ziad-saab ziad-saab requested review from a team as code owners February 1, 2024 16:41
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snaps-known-errors

Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snaps-known-errors

@ziad-saab ziad-saab requested a review from a team as a code owner February 1, 2024 17:13
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snaps-known-errors

1 similar comment
Copy link

github-actions bot commented Feb 1, 2024

Preview published: zs/snaps-known-errors

@alexandratran alexandratran self-assigned this Feb 1, 2024
Copy link

github-actions bot commented Feb 2, 2024

Preview published: zs/snaps-known-errors

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor edits and reformatted the error reference into a table for simplicity and better scannability. LGTM!

Copy link

github-actions bot commented Feb 2, 2024

Preview published: zs/snaps-known-errors

Copy link

github-actions bot commented Feb 2, 2024

Preview published: zs/snaps-known-errors

@Montoya
Copy link
Contributor

Montoya commented Feb 2, 2024

Looks great!

One callout, the alignment of inline code sections is off. They show a couple pixels below the adjacent text.

image

@Montoya Montoya merged commit 2a1ca1c into main Feb 2, 2024
6 checks passed
@Montoya Montoya deleted the zs/snaps-known-errors branch February 2, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants