Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context, examples, and images to Snaps custom UI #1225

Merged
merged 3 commits into from Mar 20, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Mar 20, 2024

Improve Snaps custom UI examples to include usage with snap_dialog, onTransaction, or onHomePage, and include screenshots of all UI components. Minor fixes to images across the site for consistency.

Preview: https://docs.metamask.io/843-improve-custom-ui/snaps/features/custom-ui/

Fixes #843
Fixes #890

Copy link

Preview published: 843-improve-custom-ui

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just found some issues in the examples.

snaps/features/custom-ui.md Outdated Show resolved Hide resolved
snaps/features/custom-ui.md Outdated Show resolved Hide resolved
snaps/features/custom-ui.md Outdated Show resolved Hide resolved
snaps/features/custom-ui.md Outdated Show resolved Hide resolved
snaps/features/custom-ui.md Outdated Show resolved Hide resolved
snaps/features/custom-ui.md Outdated Show resolved Hide resolved
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Copy link

Preview published: 843-improve-custom-ui

Copy link

Preview published: 843-improve-custom-ui

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 1cbe890 into main Mar 20, 2024
8 checks passed
@alexandratran alexandratran deleted the 843-improve-custom-ui branch March 20, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snaps page for Custom UI should have images Improve "Custom UI" section of Snaps documentation
3 participants