Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Snaps dialogs and home pages #1302

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented May 8, 2024

Description

Add feature pages under Custom UI for Snaps dialogs and home pages. Include screenshots, examples.

Clean up and make minor edits to related content for consistency, accuracy, and simplicity.

Issue(s) fixed

Fixes #1267
Fixes #1268

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@alexandratran alexandratran requested a review from Montoya May 8, 2024 21:34
@alexandratran alexandratran requested review from a team as code owners May 8, 2024 21:34
Copy link

github-actions bot commented May 8, 2024

Preview published: 1267-snaps-dialogs

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple minor suggestions ( but can leave or take them ).

Copy link

github-actions bot commented May 9, 2024

Preview published: 1267-snaps-dialogs

@alexandratran alexandratran merged commit 6a26c0e into main May 14, 2024
8 checks passed
@alexandratran alexandratran deleted the 1267-snaps-dialogs branch May 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Snaps home pages feature page Add Snaps dialogs feature page
3 participants