Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel Trezor personal sign, can't get error #11297

Closed
Xaber20110202 opened this issue Jun 15, 2021 · 2 comments
Closed

cancel Trezor personal sign, can't get error #11297

Xaber20110202 opened this issue Jun 15, 2021 · 2 comments
Labels
area-hardware hardware-trezor Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale type-bug

Comments

@Xaber20110202
Copy link

Xaber20110202 commented Jun 15, 2021

Describe the bug
When using trezor model T for personal_sign, clicking on trezor's cancel button does not get the error.

Steps to reproduce (REQUIRED)

  1. use MetaMask to call personal_sign, like
window.ethereum.sendAsync({
    from: 'TREZOR ETH ADDRESS'.toLowerCase(),
    method: 'personal_sign',
    params: ['hello', 'TREZOR ETH ADDRESS'.toLowerCase()],
}, (err, data) => {
    alert(1)
    console.log(err, data)
})
  1. confirm sign

  1. popup trezor page, and click cancel button

  1. nothing happens and no error is thrown

Expected behavior
It is expected that an error will need to be thrown, just like when making a transfer, and the following message will pop up

Screenshots
Screenshots are presented above

Browser details (please complete the following information):

  • OS: macOS BigSur 11.4
  • Hardware Wallet: Trezor Firmware version 2.4.0
  • Browser: Chrome Version 91.0.4472.77 (Official Build) (64-bit)
  • MetaMask Version: e.g. 9.6.0

Additional context (Error Messages, etc.)

@brad-decker brad-decker added hardware-trezor Sev2-normal Normal severity; minor loss of service or inconvenience. type-enhancement labels Jun 15, 2021
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-hardware hardware-trezor Sev2-normal Normal severity; minor loss of service or inconvenience. stale issues and PRs marked as stale type-bug
Projects
None yet
Development

No branches or pull requests

4 participants