Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickFollow - Find more elegant solution to strict equality check of ChainID in signTypedData params validation #11310

Closed
adonesky1 opened this issue Jun 15, 2021 · 0 comments · Fixed by #11340
Closed

QuickFollow - Find more elegant solution to strict equality check of ChainID in signTypedData params validation #11310

adonesky1 opened this issue Jun 15, 2021 · 0 comments · Fixed by #11340
Assignees
@adonesky1
Labels
area-customNetworks area-signTypedData type-refactor

Comments

@adonesky1
Copy link
Contributor

Describe the bug
We hotfix patched a bug introduced in 9.6 where valid chainId parameters passed to signTypedData were incorrectly throwing an error. The quick fix was to revert from strict equality check to basic equality check. We should loop back and find a more elegant solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonesky1 adonesky1

Labels
area-customNetworks area-signTypedData type-refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back strict equality checks in typed-message-manager MetaMask/metamask-extension
2 participants
@jacobc-eth @adonesky1