Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MV3: ensure that dapp requests sent during service worker restarts are properly handled #15052

Closed
danjm opened this issue Jun 24, 2022 · 4 comments · Fixed by #15958 or #16131
Closed

MV3: ensure that dapp requests sent during service worker restarts are properly handled #15052

danjm opened this issue Jun 24, 2022 · 4 comments · Fixed by #15958 or #16131
Assignees
@jpuri
Labels
MV3
Milestone
Milestone 1: Dev ...

Comments

@danjm
Copy link
Contributor

danjm commented Jun 24, 2022 •
edited by hilvmason
Loading

No description provided.

@danjm danjm added the MV3 label Jun 24, 2022
@danjm
Copy link
Contributor Author

danjm commented Aug 9, 2022

The solution for this may take inspiration #15337

@danjm
Copy link
Contributor Author

danjm commented Aug 9, 2022

Blocked by #14845

@hilvmason
Copy link
Contributor

this issue requires further investigation for architecture -- once #15337 is merged, @Gudahtt @jpuri @naugtur should meet to discuss technical solution.

@hilvmason hilvmason changed the title MV3: ensure that dapp requests sent during service work restarts are properly handled MV3: ensure that dapp requests sent during service worker restarts are properly handled Sep 8, 2022
@jpuri jpuri mentioned this issue Sep 23, 2022
Merged
@jpuri
Copy link
Contributor

jpuri commented Sep 23, 2022

Multiple PRs have been created to fix this issue:

  1. retry support json-rpc-middleware-stream#27
  2. Passing configuration options to JSON stream middleware providers#223
  3. Send message to inpage when extension revives #15958

We need to update provider in metamask-extension once MetaMask/providers#223 is merged.

@jpuri jpuri reopened this Sep 27, 2022
This was referenced Oct 4, 2022
Closed
Closed
@jpuri jpuri mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
MV3
Projects
None yet
Milestone
Milestone 1: Dev build ready at the e...
4 participants
@jpuri @danjm @mobularay @hilvmason