-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update knobs to controls in storybook: ConfirmAddSuggestedToken #18499
Comments
i would like to work on this issue , can you please assign it to me? |
Hey @sumitshinde-84, assigned. Thank you! Looking forward to your PR |
Great! I'll make sure to update you on the progress of the PR. If you have any specific requirements or guidelines for the migration from knobs to controls, please let me know. I'll do my best to ensure a smooth transition. Thank you! |
@georgewrmarshall Done ! |
hi @georgewrmarshall I have submitted a pull request and would greatly appreciate your kind review of it. If there are any frontend-related tasks or areas where I can contribute to further improve the user interface and user experience, I would be honored to help |
hii @georgewrmarshall now i have made changes in my new PR #18635 as you suggest me . |
hii @georgewrmarshall , |
@georgewrmarshall can you please reopen my PR #18635? i am unable to do that . |
Done |
Thanks @georgewrmarshall |
@georgewrmarshall now you can check warning message is visible, i have made changes in pr. |
@georgewrmarshall, I apologize for replying under this issue instead of the pull request. (I am unable to reply under the pull request because the bot has blocked me.) I just wanted to express my gratitude for your help in resolving the issue. Your assistance was much appreciated, and I am glad to have had the opportunity to work with you |
Thanks for your contribution @sumitshinde-84 and the help with my git issues! |
Description
Currently there are a few storybook stories still using knobs in our storybook files
*.stories.js
. knobs have been deprecated in favour of controls. It would be great to migrate these last stories from knobs to controls.This issue is to migrate the
ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js
from knobs to controlsRequirements
If you would like to take on this issue please comment but before asking to take on this issue there are a few requirements that will help complete this task:
yarn storybook
Technical Details
Acceptance Criteria
The text was updated successfully, but these errors were encountered: