Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knobs to controls in storybook: ConfirmAddSuggestedToken #18499

Closed
georgewrmarshall opened this issue Apr 6, 2023 · 13 comments · Fixed by #18635
Closed

Update knobs to controls in storybook: ConfirmAddSuggestedToken #18499

georgewrmarshall opened this issue Apr 6, 2023 · 13 comments · Fixed by #18635
Assignees
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension type-story

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Apr 6, 2023

Description

Currently there are a few storybook stories still using knobs in our storybook files *.stories.js. knobs have been deprecated in favour of controls. It would be great to migrate these last stories from knobs to controls.

This issue is to migrate the ui/pages/confirm-add-suggested-token/confirm-add-suggested-token.stories.js from knobs to controls

Screenshot 2023-04-06 at 4 39 08 PM

Requirements

If you would like to take on this issue please comment but before asking to take on this issue there are a few requirements that will help complete this task:

  • Get storybook up and running yarn storybook
  • Some knowledge of storybook is not required but would be beneficial for this task. storybook docs here

Technical Details

  • Migrate knobs to controls

Acceptance Criteria

  • knobs have been migrated to controls for listed story
  • Take Before / After screenshots of the knobs and new controls and attach to the PR
  • Tag @georgewrmarshall, @garrettbear, or @NidhiKJha in the PR to review
@georgewrmarshall georgewrmarshall added good first issue Good for newcomers type-story team-design-system All issues relating to design system in Extension labels Apr 6, 2023
@sumitshinde-84
Copy link
Contributor

i would like to work on this issue , can you please assign it to me?

@georgewrmarshall
Copy link
Contributor Author

georgewrmarshall commented Apr 11, 2023

Hey @sumitshinde-84, assigned. Thank you! Looking forward to your PR

@sumitshinde-84
Copy link
Contributor

sumitshinde-84 commented Apr 11, 2023

Great! I'll make sure to update you on the progress of the PR. If you have any specific requirements or guidelines for the migration from knobs to controls, please let me know. I'll do my best to ensure a smooth transition. Thank you!
@georgewrmarshall

@sumitshinde-84 sumitshinde-84 mentioned this issue Apr 12, 2023
6 tasks
@sumitshinde-84
Copy link
Contributor

@georgewrmarshall Done !

@sumitshinde-84
Copy link
Contributor

hi @georgewrmarshall I have submitted a pull request and would greatly appreciate your kind review of it. If there are any frontend-related tasks or areas where I can contribute to further improve the user interface and user experience, I would be honored to help

@sumitshinde-84 sumitshinde-84 mentioned this issue Apr 18, 2023
8 tasks
@sumitshinde-84
Copy link
Contributor

hii @georgewrmarshall now i have made changes in my new PR #18635 as you suggest me .

@sumitshinde-84
Copy link
Contributor

hii @georgewrmarshall ,
I dont know how but my Pull request got automatically closed .

@sumitshinde-84
Copy link
Contributor

@georgewrmarshall can you please reopen my PR #18635? i am unable to do that .

@georgewrmarshall
Copy link
Contributor Author

Done

@sumitshinde-84
Copy link
Contributor

Done

Thanks @georgewrmarshall

@sumitshinde-84
Copy link
Contributor

@georgewrmarshall now you can check warning message is visible, i have made changes in pr.

@sumitshinde-84
Copy link
Contributor

@georgewrmarshall, I apologize for replying under this issue instead of the pull request. (I am unable to reply under the pull request because the bot has blocked me.) I just wanted to express my gratitude for your help in resolving the issue. Your assistance was much appreciated, and I am glad to have had the opportunity to work with you

@georgewrmarshall
Copy link
Contributor Author

Thanks for your contribution @sumitshinde-84 and the help with my git issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension type-story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants