-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update knobs to controls in storybook: SelectQuotePopover #18500
Comments
Hey, @georgewrmarshall I am interested, can I work on it? Could you please assign it to me? |
Hey @HemanthPaila, sure thing! Looking forward to your PR |
@georgewrmarshall hey! I would like to fix this issue...can you help me out ? |
지침따러다 |
Hello @georgewrmarshall, I am interested in working on this issue. I believe I am well-suited for it because I have successfully resolved similar issues in the past when you assigned it to me. I would appreciate it if you could assign this issue to me as well. Thank you. |
As it has been a couple weeks since the issue was assigned I'm comfortable assigning more contributors. @sumitshinde-84 based on your previous PR I have assigned you the issue also. Looking forward to your PR. Thank you. Also thanks for your interest @subhajit20! Keep an eye for more good first issues I will be creating some more in the coming weeks that I can assign you if you're interested |
@georgewrmarshall can you please review my PR #18537? |
And Thank you so much for assigning issue to me. |
hii @georgewrmarshall , I have created pull request please review it . |
Thank you very much, @NidhiKJha, for merging my pull request . |
Description
Currently there are a few storybook stories still using knobs in our storybook files
*.stories.js
. knobs have been deprecated in favour of controls. It would be great to migrate these last stories from knobs to controls.This issue is to migrate the
ui/pages/swaps/select-quote-popover/select-quote-popover.stories.js
from knobs to controlsRequirements
If you would like to take on this issue please comment but before asking to take on this issue there are a few requirements that will help complete this task:
yarn storybook
Technical Details
Acceptance Criteria
The text was updated successfully, but these errors were encountered: