Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knobs to controls in storybook: SelectQuotePopover #18500

Closed
georgewrmarshall opened this issue Apr 6, 2023 · 10 comments · Fixed by #18671
Closed

Update knobs to controls in storybook: SelectQuotePopover #18500

georgewrmarshall opened this issue Apr 6, 2023 · 10 comments · Fixed by #18671
Assignees
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension type-story

Comments

@georgewrmarshall
Copy link
Contributor

Description

Currently there are a few storybook stories still using knobs in our storybook files *.stories.js. knobs have been deprecated in favour of controls. It would be great to migrate these last stories from knobs to controls.

This issue is to migrate the ui/pages/swaps/select-quote-popover/select-quote-popover.stories.js from knobs to controls

Screenshot 2023-04-06 at 4 55 49 PM

Requirements

If you would like to take on this issue please comment but before asking to take on this issue there are a few requirements that will help complete this task:

  • Get storybook up and running yarn storybook
  • Some knowledge of storybook is not required but would be beneficial for this task. storybook docs here

Technical Details

  • Migrate knobs to controls

Acceptance Criteria

  • knobs have been migrated to controls for listed story
  • Take Before / After screenshots of the knobs and new controls and attach to the PR
  • Tag @georgewrmarshall, @garrettbear, or @NidhiKJha in the PR to review
@georgewrmarshall georgewrmarshall added good first issue Good for newcomers type-story team-design-system All issues relating to design system in Extension labels Apr 6, 2023
@HemanthPaila
Copy link

Hey, @georgewrmarshall I am interested, can I work on it? Could you please assign it to me?

@georgewrmarshall
Copy link
Contributor Author

Hey @HemanthPaila, sure thing! Looking forward to your PR

@subhajit20
Copy link
Contributor

@georgewrmarshall hey! I would like to fix this issue...can you help me out ?

@rkddbsdo
Copy link

지침따러다

@sumitshinde-84
Copy link
Contributor

sumitshinde-84 commented Apr 12, 2023

Hello @georgewrmarshall, I am interested in working on this issue. I believe I am well-suited for it because I have successfully resolved similar issues in the past when you assigned it to me. I would appreciate it if you could assign this issue to me as well. Thank you.

@georgewrmarshall
Copy link
Contributor Author

georgewrmarshall commented Apr 18, 2023

As it has been a couple weeks since the issue was assigned I'm comfortable assigning more contributors. @sumitshinde-84 based on your previous PR I have assigned you the issue also. Looking forward to your PR. Thank you.

Also thanks for your interest @subhajit20! Keep an eye for more good first issues I will be creating some more in the coming weeks that I can assign you if you're interested

@sumitshinde-84
Copy link
Contributor

@georgewrmarshall can you please review my PR #18537?

@sumitshinde-84
Copy link
Contributor

As it has been a couple weeks since the issue was assigned I'm comfortable assigning more contributors. @sumitshinde-84 based on your previous PR I have assigned you the issue also. Looking forward to your PR. Thank you.

Also thanks for your interest @subhajit20! Keep an eye for more good first issues I will be creating some more in the coming weeks that I can assign you if you're interested

And Thank you so much for assigning issue to me.

@sumitshinde-84
Copy link
Contributor

hii @georgewrmarshall , I have created pull request please review it .

@sumitshinde-84
Copy link
Contributor

Thank you very much, @NidhiKJha, for merging my pull request .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers team-design-system All issues relating to design system in Extension type-story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants