Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sign message show hex string instead of utf-8 in some specific message. #23282

Open
y-pakorn opened this issue Mar 2, 2024 · 1 comment
Assignees
Labels
external-contributor regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@y-pakorn
Copy link

y-pakorn commented Mar 2, 2024

Describe the bug

When signing some specific message, Metamask shows hex string instead of its original utf-8 counterparts. This happen with only some message as I tested.

Expected behavior

With the actual message being: Sign in to VVVVVVV early access.
What I got from Metamask when I clicked sign: 0x5369676e20696e20746f2056565656565656206561726c79206163636573732e
What I SHOULD got from Metamask when I clicked sign: Sign in to VVVVVVV early access.

Screenshots/Recordings

This is from metamask

Screenshot 2567-03-02 at 15 22 44

This is from other wallet

Screenshot 2567-03-02 at 15 21 54

Steps to reproduce

Link to reproducible code

Error messages or log output

No response

Version

11.10.0

Build type

None

Browser

Other (please elaborate in the "Additional Context" section)

Operating system

MacOS

Hardware wallet

No response

Additional context

Browser: Arc

Severity

No response

@metamaskbot metamaskbot added external-contributor regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 labels Mar 2, 2024
@bschorchit bschorchit added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead Sev2-normal Normal severity; minor loss of service or inconvenience. labels Apr 3, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@jpuri jpuri self-assigned this May 2, 2024
@jpuri
Copy link
Contributor

jpuri commented May 12, 2024

Text strings that result in hex string of length 32 can give issue with personal signs, but it is more of an edge case. We display string of length 32 as hex only as it can be a hash value. More details here: #24367 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor regression-prod-11.10.0 Regression bug that was found in production in release 11.10.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
Status: Fix in Progress
Status: Fix in Progress
Development

Successfully merging a pull request may close this issue.

5 participants