Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] Confirmation redesign - Create Navigation tests #23978

Open
8 tasks
digiwand opened this issue Apr 11, 2024 · 2 comments · May be fixed by #24365
Open
8 tasks

[e2e] Confirmation redesign - Create Navigation tests #23978

digiwand opened this issue Apr 11, 2024 · 2 comments · May be fixed by #24365
Assignees
@pnarayanaswamy
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead

Comments

@digiwand
Copy link
Contributor

digiwand commented Apr 11, 2024 •
edited

ref: #23552 (comment)

Create e2e tests:

  • Navigation (signatures only)
    • I can navigate through multiple signatures
    • I can reject all signatures at once
    • I can reject/accept signatures one by one
  • Navigation (mix transaction + signatures)
    • I can navigate through multiple signatures and transactions
    • I can reject all signatures and transactions at once
    • I can reject/accept signatures and transactions one by one
@digiwand digiwand added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 11, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Apr 11, 2024
@pnarayanaswamy pnarayanaswamy self-assigned this Apr 17, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@pnarayanaswamy pnarayanaswamy removed their assignment Apr 25, 2024
@jpuri
Copy link
Contributor

jpuri commented Apr 26, 2024

Let's limit the scope of e2e to new designed confirmation pages.

@jpuri
Copy link
Contributor

jpuri commented Apr 26, 2024

Hey team! Please add your planning poker estimate with Zenhub @digiwand @pedronfigueiredo @pnarayanaswamy @seaona

@pnarayanaswamy pnarayanaswamy self-assigned this Apr 29, 2024
@pnarayanaswamy pnarayanaswamy linked a pull request May 8, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnarayanaswamy pnarayanaswamy

Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: e2e for signature navigation MetaMask/metamask-extension
5 participants
@jpuri @cryptotavares @digiwand @pnarayanaswamy @metamaskbot