Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "details" for failed transactions in history #6316

Closed
quezak opened this issue Mar 18, 2019 · 5 comments
Closed

No "details" for failed transactions in history #6316

quezak opened this issue Mar 18, 2019 · 5 comments

Comments

@quezak
Copy link

quezak commented Mar 18, 2019

Describe the bug
Transaction history shows details & etherscan link when a successful transaction is clicked.
If I click a failed transaction, nothing happens. To see the details, I need to manually go to my address's etherscan page and select the failed transaction there. Tested on both Firefox and Chromium.e

To Reproduce
Steps to reproduce the behavior:

  1. Do any failing transaction
  2. Click on the failed transaction in "History" section of the extension
  3. Nothing happens.

Expected behavior
I'd expect a "Details" section pop up below the transaction, more or less the same as for successful transactions.

Screenshots
metamask-no-failed-details

Browser details (please complete the following information):

  • OS: gentoo linux
  • Browser: Firefox 65.0, Chromium 72.0.3626.28-r1
  • MetaMask Version 6.2.2
@EtDu
Copy link
Contributor

EtDu commented Mar 29, 2019

Working on this now, recommended by @kumavis

@EtDu
Copy link
Contributor

EtDu commented Mar 29, 2019

Reproduced with V6.2.2 on latest Chrome & Firefox 65. Seems to be working fine however with latest V6.3.0 on Chrome

@kumavis
Copy link
Member

kumavis commented Mar 29, 2019

Verified working on 6.3.0

@kumavis kumavis closed this as completed Mar 29, 2019
@krungle-mataman
Copy link

Hello,

i got the same error with
OS: Windows
Browser: Chrome 75.0.xx
Metamask: 6.7.3

and i don't know if it is still an open-issue ?

@krungle-mataman
Copy link

Here just something internal concerning the eventid:

{exception: {values: [{stacktrace: {,…}, type: "TypeError", value: "t is not a function"}],…},…}
breadcrumbs: [{timestamp: 1563882539.241, category: "ui.click",…},…]
event_id: "85c4378846b046459d347c23ef808e35"
exception: {values: [{stacktrace: {,…}, type: "TypeError", value: "t is not a function"}],…}
mechanism: {data: {function: "addEventListener", handler: "bound dispatchEvent", target: "EventTarget"},…}
data: {function: "addEventListener", handler: "bound dispatchEvent", target: "EventTarget"}
handled: true
type: "instrument"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants