Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed Welcome Back dialog box do not provide any feedback #8221

Closed
xmaysonnave opened this issue Mar 20, 2020 · 2 comments
Closed

Closed Welcome Back dialog box do not provide any feedback #8221

xmaysonnave opened this issue Mar 20, 2020 · 2 comments
Labels
area-injection Relating to how the JS interface is injected into a website.

Comments

@xmaysonnave
Copy link
Contributor

Environment:
Debian Buster :
Linux andaman 5.5.10-xanmod2 #1 SMP PREEMPT Wed Mar 18 10:40:26 -03 2020 x86_64 GNU/Linux
Chrome:
Version 80.0.3987.149 (Official Build) (64-bit)
Metamask:
7.7.8

The Welcome Back dialog box when closed do not provide any feedback

ksnip_20200320-105746

Two methods are currently available to start an interaction with Metamask from Javascript:
The await provider.send("eth_requestAccounts") call or the await provider.enable() method..

When the Welcome Back dialog box is displayed users have the opportunity to immediately close the dialog box. In such situation the send method do not raise any exceptions and the enable method do not return anything. The caller is stuck in its asynchronous call...

Thanks
@xmaysonnave xmaysonnave mentioned this issue Mar 20, 2020
Closed
@jennypollack jennypollack added T06-devQuestion area-injection Relating to how the JS interface is injected into a website. labels Mar 23, 2020
@xmaysonnave
Copy link
Contributor Author

The beta https://173555-42009758-gh.circle-artifacts.com/0/builds/metamask-chrome-8.0.0.zip fixes the issue. Closing the native dialog box properly propagates an exception giving a chance to implementers to handle it properly. Thanks

@Gudahtt
Copy link
Member

Gudahtt commented Jul 28, 2020

Thanks for the report @xmaysonnave ! Great to hear that it has been fixed.

@Gudahtt Gudahtt closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-injection Relating to how the JS interface is injected into a website.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gudahtt @jennypollack @xmaysonnave