Skip to content

Commit

Permalink
Fix: Exclude devDependencies from attribution.txt
Browse files Browse the repository at this point in the history
The generated file `attribution.txt` was intended to exclude all
`devDependencies`, but a few snuck their way in anyway. The
`build:attribution` script we use to generate that file has been
updated to ensure that `devDependencies` are excluded.

The old script was deleting `devDependencies` from `package.json` in
an attempt to exclude them, but this wasn't working properly because
the package we use to find all licences was looking on-disk for them,
not walking through the dependency graph starting at our manifest.

The script now explicitly deletes `node_modules` and re-installs with
only production dependencies, so they are the only ones present on-disk
for the license checker to find.

The script now leaves the project in a state where only production
dependencies are installed, so a reminder to run `yarn setup` was added
to the end of the script

Fixes MetaMask/MetaMask-planning#2182
  • Loading branch information
Gudahtt committed Mar 6, 2024
1 parent 1097298 commit c40b13e
Show file tree
Hide file tree
Showing 4 changed files with 86,473 additions and 22,347 deletions.
Loading

0 comments on commit c40b13e

Please sign in to comment.